Author zach.ware
Recipients benjamin.peterson, docs@python, gromgull, hynek, pitrou, r.david.murray, serhiy.storchaka, stutzbach, zach.ware
Date 2014-02-25.21:50:12
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1393365013.28.0.689690627931.issue20501@psf.upfronthosting.co.za>
In-reply-to
Content
The new test passes on Windows with the whole patch applied, but fails without the changes to fileinput.py.  Is this change meant to fix behavior, or just the memory usage issue?

Just for completeness, here's the failure output (with unpatched fileinput.py):

======================================================================
FAIL: test_modes (__main__.Test_hook_encoded)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "P:\ath\to\2.7\cpython\lib\test\test_fileinput.py", line 235, in test_modes
    check('r', [u'A\n', u'B\r\n', u'C\rD\u20ac'])
  File "P:\ath\to\2.7\cpython\lib\test\test_fileinput.py", line 233, in check
    self.assertEqual(lines, expected_lines)
AssertionError: Lists differ: [u'A\n', u'B\r\n', u'C\r', u'D... != [u'A\n', u'B\r\n', u'C\rD\u20a...

First differing element 2:
C
D\u20ac

First list contains 1 additional elements.
First extra element 3:
D\u20ac

- [u'A\n', u'B\r\n', u'C\r', u'D\u20ac']
?                         -----

+ [u'A\n', u'B\r\n', u'C\rD\u20ac']

----------------------------------------------------------------------
History
Date User Action Args
2014-02-25 21:50:13zach.waresetrecipients: + zach.ware, pitrou, benjamin.peterson, stutzbach, r.david.murray, docs@python, gromgull, hynek, serhiy.storchaka
2014-02-25 21:50:13zach.waresetmessageid: <1393365013.28.0.689690627931.issue20501@psf.upfronthosting.co.za>
2014-02-25 21:50:13zach.warelinkissue20501 messages
2014-02-25 21:50:12zach.warecreate