➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author serhiy.storchaka
Recipients barry, eli.bendersky, ethan.furman, larry, serhiy.storchaka
Date 2014-02-20.07:32:56
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1392881576.89.0.123679910389.issue20679@psf.upfronthosting.co.za>
In-reply-to
Content 
Besides insignificant style nitpick ("if classdict.get('__reduce_ex__') is None" can be written as "if '__reduce_ex__' not in classdict") the patch LGTM at first glance. I'm not very familiar with Enum's complicated machinery and don't sure that no bugs left here (I'm not sure that we should sabotage pickling at all, other types have no such paranoid guard), but at least I'm sure this patch doesn't make things worse. On other hand, this doesn't look as critical bugfix and may be can wait for 3.4.1. Ethan's, Eli's and Barry's opinions have more weight in this matter.
History
Date User Action Args
2014-02-20 07:32:56serhiy.storchakasetrecipients: + serhiy.storchaka, barry, larry, eli.bendersky, ethan.furman
2014-02-20 07:32:56serhiy.storchakasetmessageid: <1392881576.89.0.123679910389.issue20679@psf.upfronthosting.co.za>
2014-02-20 07:32:56serhiy.storchakalinkissue20679 messages
2014-02-20 07:32:56serhiy.storchakacreate