Author vajrasky
Recipients larry, nadeem.vawda, serhiy.storchaka, vajrasky, zach.ware
Date 2014-02-03.15:40:25
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1391442034.36.0.521217307943.issue20185@psf.upfronthosting.co.za>
In-reply-to
Content
Here is the updated patch addressing Zachary's reviews (Thanks!). However, there are some reviews that I could not implement.

1. "This is a good candidate for a custom return converter."

I can not synchronize struct rlimit and NULL return values.

2. "Should be 'class float "PyFloatObject *" "&PyFloat_Type"'.  Using PyFloatObject
* instead of PyObject * may require some casts to PyObject * in some places, but
it's better to use the real name."

I tried it but it was like opening pandora box. It's too much effort to surpress compile errors and warnings. And casting PyFloatObject to PyObject in many places, such as functions, macros, makes me nervous. I think this one deserves a dedicated ticket.
History
Date User Action Args
2014-02-03 15:40:35vajraskysetrecipients: + vajrasky, larry, nadeem.vawda, zach.ware, serhiy.storchaka
2014-02-03 15:40:34vajraskysetmessageid: <1391442034.36.0.521217307943.issue20185@psf.upfronthosting.co.za>
2014-02-03 15:40:34vajraskylinkissue20185 messages
2014-02-03 15:40:30vajraskycreate