Author ned.deily
Recipients larry, ncoghlan, ned.deily
Date 2014-02-01.10:11:49
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1391249509.61.0.504777849278.issue20474@psf.upfronthosting.co.za>
In-reply-to
Content
Three "send timeout" test cases in test_socket were changed by a4e4facad164 for Issue12958 to be "expected failures" on OS X because of observed failures on the OS X buildbots running OS X 10.6 (Snow Leopard) and earlier.

testInterruptedSendTimeout (test.test_socket.InterruptedSendTimeoutTest) ... unexpected success
testInterruptedSendmsgTimeout (test.test_socket.InterruptedSendTimeoutTest) ... unexpected success
testInterruptedSendtoTimeout (test.test_socket.InterruptedSendTimeoutTest) ... unexpected success

It seems that the platform bugs causing the failures were fixed in OS X 10.7 so that the "expected failures" no longer fail.  However, the change in behavior had not been noticed because, until the recent change to unittest in Issue20165, unittest did not fail when there were unexpected successes.  Now it does fail, causing test_socket to fail on OS X 10.7+ for 3.4.  On 3.3 the "unexpected success" failures are silently skipped.  The attached patch changes the test cases to be skipped for OS X versions prior to 10.7 rather than to always expect failure on OS X.
History
Date User Action Args
2014-02-01 10:11:49ned.deilysetrecipients: + ned.deily, ncoghlan, larry
2014-02-01 10:11:49ned.deilysetmessageid: <1391249509.61.0.504777849278.issue20474@psf.upfronthosting.co.za>
2014-02-01 10:11:49ned.deilylinkissue20474 messages
2014-02-01 10:11:49ned.deilycreate