Author vstinner
Recipients gvanrossum, neologix, python-dev, vstinner
Date 2014-01-31.11:26:28
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1391167588.36.0.148748716536.issue20452@psf.upfronthosting.co.za>
In-reply-to
Content
> New changeset 827d948ac6aa by Victor Stinner in branch 'default':
> Issue #20452: select and selectors round (again) timeout away from zero

Let's test Charles-Francois option.

> test_timeout_rounding failed because once EPollSelector.select(timeout=0.0099) took dt=0.0086 seconds

We asked to wait 9.9 ms, which was rounding to 9 ms. But epoll_wait() took 8.6 seconds: 8.6 is smaller than 9 ms.

In my opinion, rounding away from zero is not enough. We should probably round away from zero for selectors *and* compare times using the granularity.

Let's see what buildbots say :-)
History
Date User Action Args
2014-01-31 11:26:28vstinnersetrecipients: + vstinner, gvanrossum, neologix, python-dev
2014-01-31 11:26:28vstinnersetmessageid: <1391167588.36.0.148748716536.issue20452@psf.upfronthosting.co.za>
2014-01-31 11:26:28vstinnerlinkissue20452 messages
2014-01-31 11:26:28vstinnercreate