Author benjamin.peterson
Recipients BreamoreBoy, benjamin.peterson, cameron, ethan.furman, nikratio, orsenthil
Date 2014-01-27.03:35:30
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1390793730.87.0.263499479993.issue7776@psf.upfronthosting.co.za>
In-reply-to
Content
A few comments
- Your docstring for set_tunnel claims the method sends CONNECT when it in fact doesn't touch the network at all.
- Instead of 3 parallel arrays for tunnel information, it would be better to have a TunnelInfo class to contain host/port/headers (perhaps a namedtuple?).
History
Date User Action Args
2014-01-27 03:35:30benjamin.petersonsetrecipients: + benjamin.peterson, orsenthil, cameron, nikratio, BreamoreBoy, ethan.furman
2014-01-27 03:35:30benjamin.petersonsetmessageid: <1390793730.87.0.263499479993.issue7776@psf.upfronthosting.co.za>
2014-01-27 03:35:30benjamin.petersonlinkissue7776 messages
2014-01-27 03:35:30benjamin.petersoncreate