Message209071
Scanned the whole patch, especially the type changes. This looks like a solid approach to me.
For 3.5, PEP 457 might want to consider proposing a tp_sig slot and splitting the signature out at type creation time rather than on attribute lookup. The current dynamic approach is fine for 3.4, though. |
|
Date |
User |
Action |
Args |
2014-01-24 13:50:26 | ncoghlan | set | recipients:
+ ncoghlan, gvanrossum, tim.peters, barry, brett.cannon, larry, skrah, meador.inge, zach.ware, yselivanov |
2014-01-24 13:50:26 | ncoghlan | set | messageid: <1390571426.62.0.89189566021.issue20189@psf.upfronthosting.co.za> |
2014-01-24 13:50:26 | ncoghlan | link | issue20189 messages |
2014-01-24 13:50:26 | ncoghlan | create | |
|