Message208974
> - you replaced the _AcquireFutures context manager on all futures with an >individual lock. In my opinion, it should be changed in a different patch. I >don't know which option is better, but if it is changed, it should be changed >in the whole file.
I can pursue the replacement of _AcquireFutures in a different patch, however I don't necessarily agree that it should be changed in the whole file. as_completed() is different than wait(), since wait() is obligated to return done and notdone Futures, which might require a different implementation. Initially, it may be better to only change as_completed(), where there is a clear concurrency win. |
|
Date |
User |
Action |
Args |
2014-01-23 18:26:14 | glangford | set | recipients:
+ glangford, bquinlan, mark.dickinson, vstinner |
2014-01-23 18:26:14 | glangford | set | messageid: <1390501574.92.0.253419196403.issue20297@psf.upfronthosting.co.za> |
2014-01-23 18:26:14 | glangford | link | issue20297 messages |
2014-01-23 18:26:14 | glangford | create | |
|