Author cjwelborn
Recipients cjwelborn, cool-RR, pitrou, serhiy.storchaka
Date 2014-01-23.04:29:41
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1390451383.6.0.345361951556.issue20218@psf.upfronthosting.co.za>
In-reply-to
Content
Ram Rachum (and to whom it may concern):

This patch was missing the size argument for readlines(), and it did not match the overall style of pathlib.py. (using ''' instead of """, and other docstring style). It also clobbered the builtin 'file'.

I've attached another patch that tries very hard to match that 'style', and wrote tests that try to match what the original 'io' functions test for.

This is my first patch for python-dev, I am attaching it in the hope it will help resolve the issue, or generate more discussion about it.

I ran both the individual test_pathlib tests, and the entire test suite. Also, the patchcheck sanity test.
History
Date User Action Args
2014-01-23 04:29:43cjwelbornsetrecipients: + cjwelborn, pitrou, cool-RR, serhiy.storchaka
2014-01-23 04:29:43cjwelbornsetmessageid: <1390451383.6.0.345361951556.issue20218@psf.upfronthosting.co.za>
2014-01-23 04:29:43cjwelbornlinkissue20218 messages
2014-01-23 04:29:42cjwelborncreate