Author serhiy.storchaka
Recipients Arfrever, benjamin.peterson, ezio.melotti, giampaolo.rodola, serhiy.storchaka, vstinner
Date 2014-01-22.21:38:38
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1390426718.55.0.00709298175321.issue18695@psf.upfronthosting.co.za>
In-reply-to
Content
You have eaten "return NULL;" in posix_mkfifo.

"from test.test_support import TESTFN_UNICODE, TESTFN_ENCODING" can fail. The simplest solution is just initialize them to None by default in test_support.

If TESTFN_UNICODE.encode(TESTFN_ENCODING) fails (on POSIX locale), it will be better to run tests with unicode(TESTFN, 'ascii') than skip them.

Tests should check that results for unicode filename is same as for str filename.

As far as Victor have doubts, we should ask Benjamin.
History
Date User Action Args
2014-01-22 21:38:38serhiy.storchakasetrecipients: + serhiy.storchaka, vstinner, giampaolo.rodola, benjamin.peterson, ezio.melotti, Arfrever
2014-01-22 21:38:38serhiy.storchakasetmessageid: <1390426718.55.0.00709298175321.issue18695@psf.upfronthosting.co.za>
2014-01-22 21:38:38serhiy.storchakalinkissue18695 messages
2014-01-22 21:38:38serhiy.storchakacreate