Author nadeem.vawda
Recipients larry, meador.inge, nadeem.vawda, serhiy.storchaka
Date 2014-01-22.20:58:17
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1390424298.35.0.557979403542.issue20193@psf.upfronthosting.co.za>
In-reply-to
Content
The bz2 patch looks good to me, aside from a nit with the docstring for
BZ2Compressor.__init__.

The lzma patch produces a bunch of test failures for me. It looks like
the __init__ methods for LZMACompressor and LZMADecompressor aren't
accepting keyword args:

    ☿ ./python -c 'import lzma; lzma.LZMACompressor(format=lzma.FORMAT_XZ)'                                                                                                                                                                                                                
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
    TypeError: __init__ does not take keyword arguments

    ☿ ./python -c 'import lzma; lzma.LZMADecompressor(format=lzma.FORMAT_AUTO)'                                                                                                                                                                                                            
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
    TypeError: __init__ does not take keyword arguments
History
Date User Action Args
2014-01-22 20:58:18nadeem.vawdasetrecipients: + nadeem.vawda, larry, meador.inge, serhiy.storchaka
2014-01-22 20:58:18nadeem.vawdasetmessageid: <1390424298.35.0.557979403542.issue20193@psf.upfronthosting.co.za>
2014-01-22 20:58:18nadeem.vawdalinkissue20193 messages
2014-01-22 20:58:17nadeem.vawdacreate