➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author taleinat
Recipients Yury.Selivanov, brett.cannon, georg.brandl, larry, serhiy.storchaka, taleinat, vajrasky, zach.ware
Date 2014-01-22.10:06:22
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1390385182.94.0.773039222946.issue20341@psf.upfronthosting.co.za>
In-reply-to
Content 
My only comment from reviewing the patch is that you seem to have used NULLABLE_PY_SSIZE_T_INITIALIZE by accident one time in int_converter (in clinic.py).

Other than that, as you already know, make sure to return 1 in both converters in the "if (arg == Py_None)" branches.
History
Date User Action Args
2014-01-22 10:06:22taleinatsetrecipients: + taleinat, brett.cannon, georg.brandl, larry, Yury.Selivanov, zach.ware, serhiy.storchaka, vajrasky
2014-01-22 10:06:22taleinatsetmessageid: <1390385182.94.0.773039222946.issue20341@psf.upfronthosting.co.za>
2014-01-22 10:06:22taleinatlinkissue20341 messages
2014-01-22 10:06:22taleinatcreate