Author acdha
Recipients acdha, zaytsev
Date 2014-01-07.18:29:08
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1389119348.8.0.910394570799.issue20164@psf.upfronthosting.co.za>
In-reply-to
Content
Other than hoisting the warnings import to the top (PEP-8) that seems entirely reasonable to me. The user report which we got was confusing because it was non-obvious where it came from - a warning or other pointer would have helped the original reporter get an idea as to what was failing earlier.

The other two changes I'd suggest would be documentation updates:

os.path.expanduser noting that KeyError may be raised when HOME is undefined and pwd.getpwuid fails for the active user

pwd.getpwuid noting that KeyErrors will be raised when the underlying POSIX call fails
History
Date User Action Args
2014-01-07 18:29:08acdhasetrecipients: + acdha, zaytsev
2014-01-07 18:29:08acdhasetmessageid: <1389119348.8.0.910394570799.issue20164@psf.upfronthosting.co.za>
2014-01-07 18:29:08acdhalinkissue20164 messages
2014-01-07 18:29:08acdhacreate