Author serhiy.storchaka
Recipients lemburg, loewis, serhiy.storchaka
Date 2013-12-21.23:38:34
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <13879211.rAT1KLZY4E@raxxla>
In-reply-to <52B60A58.8070106@egenix.com>
Content
> * the patch seems to include some unrelated changes, e.g. the
>   devanagari fixes and a few new mappings

May be. In any case I have added issue20027 as dependency. New mappings were 
added when enable UTF-8 locales in makelocalealias.py (I can split this in 
separate issue).

> * the optimize step is called twice for some reason - is this
>   intended ? if yes, please add a comment why this is done

Actually we should call it in a loop while the size of the table is decreased.

> * the patch would need some tests to make sure that the removed
>   aliases indeed still map to the correct C locale strings

Currently the makelocalealias.py is such manual test. test_locale contains 
multiple tests for different locales. I'll add several new cases.
History
Date User Action Args
2013-12-21 23:38:34serhiy.storchakasetrecipients: + serhiy.storchaka, lemburg, loewis
2013-12-21 23:38:34serhiy.storchakalinkissue20046 messages
2013-12-21 23:38:34serhiy.storchakacreate