Message206507
Assigning to myself, since my private 100% coverage test suite
would have to be updated as well.
I have just glanced at the patch and only have some superficial
remarks:
In any case, I would prefer a patch without stylistic changes. Elimination of "return" is a personal preference, so are the
whitespace changes.
Listing the tests explicitly is sometimes helpful, e.g. one can
comment out tests when tracking down a refleak.
Curiously enough, testing with a "polluted" context is also useful,
since all functions must handle contexts with flags that are already
set.
Finally, I *suspect* no one is using the command line arguments any
more. They were probably used heavily during the design phase of
decimal.py. |
|
Date |
User |
Action |
Args |
2013-12-18 11:57:24 | skrah | set | recipients:
+ skrah, rhettinger, facundobatista, mark.dickinson, ezio.melotti, zach.ware |
2013-12-18 11:57:24 | skrah | set | messageid: <1387367844.47.0.47107486885.issue20008@psf.upfronthosting.co.za> |
2013-12-18 11:57:24 | skrah | link | issue20008 messages |
2013-12-18 11:57:23 | skrah | create | |
|