This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author skrah
Recipients alexandre.vassalotti, loewis, ncoghlan, pitrou, skrah, vstinner
Date 2013-12-13.22:21:49
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1386973309.33.0.570109781225.issue19972@psf.upfronthosting.co.za>
In-reply-to
Content
I just see that it should be:

static void
pickle_free(PyObject *m)
...


Even then, the cast is necessary, otherwise you get this warning:

/home/stefan/hg/cpython/Modules/_pickle.c:7450:1: warning: initialization from incompatible pointer type [enabled by default]
/home/stefan/hg/cpython/Modules/_pickle.c:7450:1: warning: (near initialization for '_picklemodule.m_free') [enabled by default]


I agree that it would be nice to update the PEP, but I guess that
would be Martin's call.
History
Date User Action Args
2013-12-13 22:21:49skrahsetrecipients: + skrah, loewis, ncoghlan, pitrou, vstinner, alexandre.vassalotti
2013-12-13 22:21:49skrahsetmessageid: <1386973309.33.0.570109781225.issue19972@psf.upfronthosting.co.za>
2013-12-13 22:21:49skrahlinkissue19972 messages
2013-12-13 22:21:49skrahcreate