Author vstinner
Recipients docs@python, gvanrossum, neologix, python-dev, vstinner
Date 2013-12-08.11:22:13
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1386501734.2.0.686356422804.issue19876@psf.upfronthosting.co.za>
In-reply-to
Content
I don't like generic "except OSError: pass". Here is a first patch for epoll() to use "except FileNotFoundError: pass" instead. Kqueue selector should also be patched.

I tested to close epoll FD (os.close(epoll.fileno())): on Linux 3.11, epoll.unregister(fd) and epoll.close() don't raise an error. Strange. (The C code looks correct).

(About the commit: I don't like "_fileobj_lookup" method name, we loose the information (compared to "_fileobj_to_fd" name) that the method returns a file dscriptor. I would prefer "_get_fd" or "_get_fileobj_fd".)
History
Date User Action Args
2013-12-08 11:22:14vstinnersetrecipients: + vstinner, gvanrossum, neologix, docs@python, python-dev
2013-12-08 11:22:14vstinnersetmessageid: <1386501734.2.0.686356422804.issue19876@psf.upfronthosting.co.za>
2013-12-08 11:22:14vstinnerlinkissue19876 messages
2013-12-08 11:22:13vstinnercreate