Author neologix
Recipients docs@python, gvanrossum, neologix, vstinner
Date 2013-12-06.22:59:10
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CAH_1eM0KE-7Yu0_VEm+Bw8DcD_FoxoM_ghKLLig42K5hc-ojSQ@mail.gmail.com>
In-reply-to <1386368116.71.0.314149961478.issue19876@psf.upfronthosting.co.za>
Content
> Guido van Rossum added the comment:
>
> Here's an attempt at fixing the ValueError.
>
> I don't like the exhaustive search much, but the alternative is to maintain an inverse dict.  What do you think?

I was going to suggest such an exhaustive search.
I think it's the cleanest/simplest solution, and the performance
overhead is IMO completely unimportant since it's not supposed to
happen often, and if the key isn't found we're going to raise an
exception anyway.

So if we want to handle this case (and I think we should to be
consistent), that's the best way to go.

But I think that OSError should still be caught in
EpollSelector.unregister(): since if the FD is closed before,
epoll.unregister() will raise ENOENT/EBADF since the FD will have
automatically been removed (exactly as for kqueue according to the man
page).
History
Date User Action Args
2013-12-06 22:59:10neologixsetrecipients: + neologix, gvanrossum, vstinner, docs@python
2013-12-06 22:59:10neologixlinkissue19876 messages
2013-12-06 22:59:10neologixcreate