➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author alexandre.vassalotti
Recipients Arfrever, alexandre.vassalotti, larry, pitrou, serhiy.storchaka, vstinner
Date 2013-11-30.04:23:16
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1385785398.15.0.402426869966.issue19780@psf.upfronthosting.co.za>
In-reply-to
Content 
> Test data are too small, they all less than frame size.

Ah, good point! It seems your patch helps when the reads are *very* slow and buffering is disabled.

### unpickle_file ###
Min: 1.125320 -> 0.663367: 1.70x faster
Avg: 1.237206 -> 0.701303: 1.76x faster
Significant (t=30.77)
Stddev: 0.12031 -> 0.02634: 4.5682x smaller

That certainly is a nice improvement though that seems to be fairly narrow use case. With more normal read times, the improvement diminishes greatly:

### unpickle_file ###
Min: 0.494841 -> 0.466837: 1.06x faster
Avg: 0.540923 -> 0.511165: 1.06x faster
Significant (t=4.10)
Stddev: 0.03740 -> 0.03510: 1.0657x smaller
History
Date User Action Args
2013-11-30 04:23:18alexandre.vassalottisetrecipients: + alexandre.vassalotti, pitrou, vstinner, larry, Arfrever, serhiy.storchaka
2013-11-30 04:23:18alexandre.vassalottisetmessageid: <1385785398.15.0.402426869966.issue19780@psf.upfronthosting.co.za>
2013-11-30 04:23:18alexandre.vassalottilinkissue19780 messages
2013-11-30 04:23:17alexandre.vassalotticreate