This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author alexandre.vassalotti
Recipients Arfrever, alexandre.vassalotti, larry, pitrou, serhiy.storchaka, vstinner
Date 2013-11-27.07:03:08
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1385535790.71.0.393337888652.issue19780@psf.upfronthosting.co.za>
In-reply-to
Content
Serhiy, I am not able to reproduce your results. I don't get any significant performance improvements with your patch.

22:34:03 [ ~/PythonDev/cpython-baseline ]$ ./python.exe -m timeit "import pickle" "with open('test.pickle4', 'rb', buffering=0) as f: pickle.load(f)"
100 loops, best of 3: 9.26 msec per loop

22:36:13 [ ~/PythonDev/cpython ]$ ./python.exe -m timeit "import pickle" "with open('test.pickle4', 'rb', buffering=0) as f: pickle.load(f)"
100 loops, best of 3: 9.28 msec per loop

I wrote a benchmark to simulate slow reads. But again, there is no performance difference with the patch.

22:24:56 [ ~/PythonDev/benchmarks ]$ ./perf.py -v -b unpickle_file ../cpython-baseline/python.exe ../cpython/python.exe
### unpickle_file ###
Min: 1.103715 -> 1.103666: 1.00x faster
Avg: 1.158279 -> 1.146820: 1.01x faster
Not significant
Stddev: 0.04127 -> 0.03273: 1.2608x smaller
History
Date User Action Args
2013-11-27 07:03:10alexandre.vassalottisetrecipients: + alexandre.vassalotti, pitrou, vstinner, larry, Arfrever, serhiy.storchaka
2013-11-27 07:03:10alexandre.vassalottisetmessageid: <1385535790.71.0.393337888652.issue19780@psf.upfronthosting.co.za>
2013-11-27 07:03:10alexandre.vassalottilinkissue19780 messages
2013-11-27 07:03:10alexandre.vassalotticreate