This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author pitrou
Recipients Arfrever, alexandre.vassalotti, larry, pitrou, serhiy.storchaka
Date 2013-11-26.12:58:29
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1385470710.49.0.400622099196.issue19780@psf.upfronthosting.co.za>
In-reply-to
Content
Bad wording perhaps, but:

+                    if not final:
+                        n += 9  # next frame header
                     write = self.file_write
                     write(FRAME)
                     write(pack("<Q", n))

does change how the frame length is calculated and emitted in the pickle stream.

This is not compliant with how the PEP defines it (the frame size doesn't include the header of the next frame):
http://www.python.org/dev/peps/pep-3154/#framing

> All tests are passed with this optimization

Well, perhaps there are not enough tests :-) But the protocol is standardized so that other people can implement it. The reference implementation can't do something different than the PEP does.
History
Date User Action Args
2013-11-26 12:58:30pitrousetrecipients: + pitrou, larry, alexandre.vassalotti, Arfrever, serhiy.storchaka
2013-11-26 12:58:30pitrousetmessageid: <1385470710.49.0.400622099196.issue19780@psf.upfronthosting.co.za>
2013-11-26 12:58:30pitroulinkissue19780 messages
2013-11-26 12:58:29pitroucreate