Message204448
The attached patch turns running kill_python(_d).exe into a PreBuildEvent in pythoncore.vcxproj. This should guarantee that kill_python(_d).exe is always run to guarantee no zombie pythons in the background can prevent overwriting the Python dll. The pythoncore project already depends on the kill_python project, so kill_python should always be built and ready before this PreBuildEvent fires. The patch also removes the separate building and running of kill_python_d.exe from the buildbot build scripts, since it should be unnecessary with the patch to pythoncore.vcxproj.
Tim Peters, this patch was partly inspired by your issues in #19779; I suspect that perhaps your rebuild didn't take due to the segfaulted interpreter still hanging around in the background since the same thing happened to me doing a rebuild from the command line. Would you mind testing this patch to see if it would have helped in your case? Steps to test should be something like:
- update to e39db21df580
- build, run test_concurrent_futures (expect segfault)
- update to default
- rebuild, run test_concurrent_futures (expect build error and segfault again)
- apply patch
- rebuild, run test_concurrent_futures (expect success (or usual result)) |
|
Date |
User |
Action |
Args |
2013-11-26 04:45:31 | zach.ware | set | recipients:
+ zach.ware, tim.peters, tim.golden, brian.curtin |
2013-11-26 04:45:31 | zach.ware | set | messageid: <1385441131.37.0.761786658191.issue19788@psf.upfronthosting.co.za> |
2013-11-26 04:45:31 | zach.ware | link | issue19788 messages |
2013-11-26 04:45:30 | zach.ware | create | |
|