This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author gvanrossum
Recipients aba, gvanrossum, vstinner
Date 2013-11-13.18:59:19
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1384369160.05.0.0150921429713.issue19566@psf.upfronthosting.co.za>
In-reply-to
Content
TBH the test structure is also rather fragile.  I need to think about it more; the global state to hold the current test instance smells, as do the various class-level functions (waitpid(), WIFEXITED() etc.) that aren't methods but used as mock functions.  The huge piles of mock.patch decorators should have tipped me off during the review, but I was more focused on the implementation instead of on the tests. :-(

The smallest fix to prevent one breaking test from breaking all following tests is just to remove the assert.  The next smallest fix is to use addCleanup() instead of tearDown() to reset ChildWatcherTestsMixin.instance.  The next fix would be huge (refactor the tests completely) and I don't want to go there.

Anthony, can you come up with a fix along the lines you suggested?  You can submit this to the Tulip repo first (let me review it).
History
Date User Action Args
2013-11-13 18:59:20gvanrossumsetrecipients: + gvanrossum, vstinner, aba
2013-11-13 18:59:20gvanrossumsetmessageid: <1384369160.05.0.0150921429713.issue19566@psf.upfronthosting.co.za>
2013-11-13 18:59:20gvanrossumlinkissue19566 messages
2013-11-13 18:59:19gvanrossumcreate