Message202760
Hmm... That fix works, and if you're concerned about the buildbots, by all means check it in.
But I think the root cause is a poor API for initializing ChildWatchers. This is currently done at the end of __init__() -- it calls self.set_loop() which is implemented by the subclass.
I think the right fix is to change the protocol to separate out the constructor from the set_loop() call (which also isn't a great name, since it does so much more -- maybe it can be called link_loop()?). This is more cumbersome (esp. for the tests), but it really rubs me the wrong way that you have to to initialize the subclass before initializing the base class. |
|
Date |
User |
Action |
Args |
2013-11-13 16:47:00 | gvanrossum | set | recipients:
+ gvanrossum, vstinner |
2013-11-13 16:47:00 | gvanrossum | set | messageid: <1384361220.56.0.249631893154.issue19566@psf.upfronthosting.co.za> |
2013-11-13 16:47:00 | gvanrossum | link | issue19566 messages |
2013-11-13 16:47:00 | gvanrossum | create | |
|