This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author gvanrossum
Recipients gvanrossum, vstinner
Date 2013-11-13.16:47:00
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <>
Hmm...  That fix works, and if you're concerned about the buildbots, by all means check it in.

But I think the root cause is a poor API for initializing ChildWatchers.  This is currently done at the end of __init__() -- it calls self.set_loop() which is implemented by the subclass.

I think the right fix is to change the protocol to separate out the constructor from the set_loop() call (which also isn't a great name, since it does so much more -- maybe it can be called link_loop()?).   This is more cumbersome (esp. for the tests), but it really rubs me the wrong way that you have to to initialize the subclass before initializing the base class.
Date User Action Args
2013-11-13 16:47:00gvanrossumsetrecipients: + gvanrossum, vstinner
2013-11-13 16:47:00gvanrossumsetmessageid: <>
2013-11-13 16:47:00gvanrossumlinkissue19566 messages
2013-11-13 16:47:00gvanrossumcreate