This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author ncoghlan
Recipients Arfrever, christian.heimes, ncoghlan, neologix, pitrou, python-dev, serhiy.storchaka
Date 2013-10-29.12:04:09
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1383048250.39.0.426200501933.issue19183@psf.upfronthosting.co.za>
In-reply-to
Content
Christian's general approach looks fine to me - consolidating the "kind" hashes (i.e. byte sequences, numbers and pointers) into one place independent of any particular type implementation makes sense to me, and the clear abstraction of "What is a hash function?" from Python's point of view is a good thing for embedding purposes.

If you get the PEP updated accordingly, we should be able to get that formally accepted in fairly short order. (I had some other suggestions in the review, but they aren't relevant to accepting the PEP).

Regarding the concerns about a potential performance impact for unaligned memory access, I think that can be better assessed *after* the simpler patch is merged and it's easier for people to get hold of the new hash implementation. However, the PEP should mention the concern, and note it as something we will be keeping a close eye on during the beta period.
History
Date User Action Args
2013-10-29 12:04:10ncoghlansetrecipients: + ncoghlan, pitrou, christian.heimes, Arfrever, neologix, python-dev, serhiy.storchaka
2013-10-29 12:04:10ncoghlansetmessageid: <1383048250.39.0.426200501933.issue19183@psf.upfronthosting.co.za>
2013-10-29 12:04:10ncoghlanlinkissue19183 messages
2013-10-29 12:04:09ncoghlancreate