Author ncoghlan
Recipients Arfrever, brett.cannon, eric.snow, ncoghlan, pje
Date 2013-10-29.10:02:09
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1383040930.02.0.68875000133.issue19413@psf.upfronthosting.co.za>
In-reply-to
Content
Patch mostly looks good to me, but there should be a second test ensuring that the loader attribute gets *replaced*, even if it is already set to something else.

A similar test structure to the existing one should work, but replacing the "del types.__loader__" with:

    expected_loader_type = type(types.__loader__)
    types.__loader__ = "this will be replaced by the reload"

and then later:

    assertIs(type(types.__loader__), expected_loader_type)
History
Date User Action Args
2013-10-29 10:02:10ncoghlansetrecipients: + ncoghlan, brett.cannon, pje, Arfrever, eric.snow
2013-10-29 10:02:10ncoghlansetmessageid: <1383040930.02.0.68875000133.issue19413@psf.upfronthosting.co.za>
2013-10-29 10:02:10ncoghlanlinkissue19413 messages
2013-10-29 10:02:09ncoghlancreate