Message200522
That patch looks good except please don't call it wait_for(), since there's already tasks.wait_for(). You can call it run_until().
Having to pass the loop to sleep() is only really required in the tests -- there was a movement a while ago (started by Alex Gaynor and supported by Glyph) to always pass in an explicit loop; my compromise was to force the tests to always pass in a loop (by using set_event_loop(None)). |
|
Date |
User |
Action |
Args |
2013-10-19 23:47:44 | gvanrossum | set | recipients:
+ gvanrossum, pitrou, koobs |
2013-10-19 23:47:44 | gvanrossum | set | messageid: <1382226464.9.0.370739790957.issue19305@psf.upfronthosting.co.za> |
2013-10-19 23:47:44 | gvanrossum | link | issue19305 messages |
2013-10-19 23:47:44 | gvanrossum | create | |
|