This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author dsuch
Recipients docs@python, dsuch
Date 2013-09-25.23:33:02
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1380151982.82.0.304891420803.issue19095@psf.upfronthosting.co.za>
In-reply-to
Content
Hello,

I'd like to suggest adding a simple note to SSLSocket.getpeercert stating that it will always return None if do_handshake has never been called.

This is not the default behaviour, by default SSLSocket.__init__'s do_handshake_on_connect is True so .getpeercert nicely returns a cert (assuming the usual caveats - the other side offers a certificate and cert_reqs is not CERT_NONE).

However, I've just been debugging a someone else's server and I spent some time figuring out why client certificates weren't available - turned out this was because do_handshake was never called (PySSL_SSLdo_handshake in _ssl.c).

Adding a single-sentence line will certainly be very helpful.

Many thanks!
History
Date User Action Args
2013-09-25 23:33:02dsuchsetrecipients: + dsuch, docs@python
2013-09-25 23:33:02dsuchsetmessageid: <1380151982.82.0.304891420803.issue19095@psf.upfronthosting.co.za>
2013-09-25 23:33:02dsuchlinkissue19095 messages
2013-09-25 23:33:02dsuchcreate