Author barry
Recipients Arfrever, akuchling, barry, benjamin.peterson, christian.heimes, georg.brandl, giampaolo.rodola, inc0, josiahcarlson, larry, neologix, pitrou, serhiy.storchaka, stutzbach
Date 2013-09-24.13:30:54
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <20130924093056.4fb5d265@anarchist>
In-reply-to <1380028328.22.0.956499669473.issue16038@psf.upfronthosting.co.za>
Content
On Sep 24, 2013, at 01:12 PM, Giampaolo Rodola' wrote:

>Giampaolo Rodola' added the comment:
>
>I believe the problem is the set of next_retr_data attribute here:
>
>    def test_retrlines_too_long(self):
>        self.server.handler.next_retr_data = 'x' * self.client.maxline * 2
>
>...because self.server.handler runs in a different thread (different than the
>main one, which is where the setattr() occurs).  We should introduce a new
>command in the dummy FTP server which sets next_retr_data from within the
>server thread itself. Will try to work on a patch later this week (I'm sorry
>but I can't make it earlier).

+1 - that explanation makes a lot of sense, thanks!

Currently 2.6.9rc1 is planned for Monday 30-September.  It would be nice to
get this one in before then, but if not that's okay.  I think it's fairly low
risk.
History
Date User Action Args
2013-09-24 13:30:55barrysetrecipients: + barry, akuchling, georg.brandl, josiahcarlson, pitrou, larry, giampaolo.rodola, christian.heimes, benjamin.peterson, stutzbach, Arfrever, neologix, serhiy.storchaka, inc0
2013-09-24 13:30:55barrylinkissue16038 messages
2013-09-24 13:30:54barrycreate