Author r.david.murray
Recipients Arfrever, akuchling, barry, benjamin.peterson, christian.heimes, georg.brandl, giampaolo.rodola, larry, python-dev, r.david.murray, serhiy.storchaka
Date 2013-09-15.17:20:28
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1379265628.89.0.563333639875.issue16042@psf.upfronthosting.co.za>
In-reply-to
Content
I'm not sure what Serhiy means by "is blocked", but the second half makes sense: readline(0) on a file will return the empty string, but here it will read one character and return it.  Like he says, it doesn't break anything in the context of this bug fix, but it is an API bug.  Unless I'm missing something his replacement also has a bug, though: it won't add the \n to the returned string.

A minimal fix for the API bug would be to extend the 'if size' with an elif for 0 that returns the empty string.
History
Date User Action Args
2013-09-15 17:20:28r.david.murraysetrecipients: + r.david.murray, barry, akuchling, georg.brandl, larry, giampaolo.rodola, christian.heimes, benjamin.peterson, Arfrever, python-dev, serhiy.storchaka
2013-09-15 17:20:28r.david.murraysetmessageid: <1379265628.89.0.563333639875.issue16042@psf.upfronthosting.co.za>
2013-09-15 17:20:28r.david.murraylinkissue16042 messages
2013-09-15 17:20:28r.david.murraycreate