➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vajrasky
Recipients ezio.melotti, neologix, vajrasky, vstinner
Date 2013-09-15.09:06:36
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1379235996.43.0.984192675751.issue18994@psf.upfronthosting.co.za>
In-reply-to
Content 
Charles-François Natali, sorry I just noticed Ezio's comment. The all_ins function return -1 on failure and 0 on success.

I use this form:

    if (all_ins(m))
        return NULL;

because I follow the example in Modules/posixmodule.c. If this form:
    
    if (all_ins(m) < 0)
        return NULL;
    
is better, then so be it, here is the patch to accommodate Ezio's suggestion.
History
Date User Action Args
2013-09-15 09:06:36vajraskysetrecipients: + vajrasky, vstinner, ezio.melotti, neologix
2013-09-15 09:06:36vajraskysetmessageid: <1379235996.43.0.984192675751.issue18994@psf.upfronthosting.co.za>
2013-09-15 09:06:36vajraskylinkissue18994 messages
2013-09-15 09:06:36vajraskycreate