Message 197553 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	scoder
Recipients	eli.bendersky, ethan.furman, flox, jcea, jkloth, ncoghlan, python-dev, scoder
Date	2013-09-13.06:23:49
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1379053430.0.0.289945674891.issue17741@psf.upfronthosting.co.za>
In-reply-to

Content
The way the XMLPullParser is implemented in lxml.etree now is that it simply inherits from XMLParser. This would also make sense for ElementTree, even before supporting arbitrary targets. The patch in ticket #18990 makes this simple to do. For reference, here is the implementation in lxml. Iterparse: https://github.com/lxml/lxml/blob/master/src/lxml/iterparse.pxi XMLPullParser: https://github.com/lxml/lxml/blob/d9f7cd8d12a27cafc4d65c6e280ea36156e3b837/src/lxml/parser.pxi#L1357 SAX based parser that collects events and/or maps parser callbacks to callbacks on the target object: https://github.com/lxml/lxml/blob/master/src/lxml/saxparser.pxi

The way the XMLPullParser is implemented in lxml.etree now is that it simply inherits from XMLParser. This would also make sense for ElementTree, even before supporting arbitrary targets. The patch in ticket #18990 makes this simple to do.

For reference, here is the implementation in lxml.

Iterparse:

https://github.com/lxml/lxml/blob/master/src/lxml/iterparse.pxi

XMLPullParser:

https://github.com/lxml/lxml/blob/d9f7cd8d12a27cafc4d65c6e280ea36156e3b837/src/lxml/parser.pxi#L1357

SAX based parser that collects events and/or maps parser callbacks to callbacks on the target object:

https://github.com/lxml/lxml/blob/master/src/lxml/saxparser.pxi

History
Date	User	Action	Args
2013-09-13 06:23:50	scoder	set	recipients: + scoder, jcea, ncoghlan, jkloth, eli.bendersky, flox, ethan.furman, python-dev
2013-09-13 06:23:50	scoder	set	messageid: <1379053430.0.0.289945674891.issue17741@psf.upfronthosting.co.za>
2013-09-13 06:23:49	scoder	link	issue17741 messages
2013-09-13 06:23:49	scoder	create