Author scoder
Recipients eli.bendersky, flox, jcea, ncoghlan, python-dev, scoder
Date 2013-08-25.14:21:31
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1377440493.14.0.227750516647.issue17741@psf.upfronthosting.co.za>
In-reply-to
Content
I attached a patch that removes the IncrementalParser class and merges its functionality into the _IterParseIterator. It thus retains most of the refactoring without adding new functionality and/or APIs.

I did not take a look if anything else from later changes needs to be reverted, neither did I update the documentation. I guess the newly added doc sections can just be deleted.

One thing that is still dubious is the requirement for the _setevents() method on the parser instance. That was already a flaw before Antoine's change, although it only hit if the C parser was used. It now affects both the Python parser and the C parser. It's not a regression because code that relies on it not being used is broken when it is being used. However, we should be aware that we are promoting a quirk to a visible API here. I don't see it as a real problem, given that it's an internal API (and thus an implementation detail), that's why I left it in. It should eventually be replaced by a proper setup based on the parser target.
History
Date User Action Args
2013-08-25 14:21:33scodersetrecipients: + scoder, jcea, ncoghlan, eli.bendersky, flox, python-dev
2013-08-25 14:21:33scodersetmessageid: <1377440493.14.0.227750516647.issue17741@psf.upfronthosting.co.za>
2013-08-25 14:21:33scoderlinkissue17741 messages
2013-08-25 14:21:32scodercreate