This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author vstinner
Recipients gregory.p.smith, neologix, pitrou, sbt, vstinner
Date 2013-08-21.22:26:11
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1377123972.12.0.476433854562.issue18763@psf.upfronthosting.co.za>
In-reply-to
Content
Your change looks perfectly valid, except this minor nit:

+        self.assertTrue(remaining_fds <= set([0, 1, 2]))

Using self.assertLessEqual() would provide better message on error.

Note: with the PEP 446, you would not have to care of closing file descriptors :-D
History
Date User Action Args
2013-08-21 22:26:12vstinnersetrecipients: + vstinner, gregory.p.smith, pitrou, neologix, sbt
2013-08-21 22:26:12vstinnersetmessageid: <1377123972.12.0.476433854562.issue18763@psf.upfronthosting.co.za>
2013-08-21 22:26:12vstinnerlinkissue18763 messages
2013-08-21 22:26:11vstinnercreate