Author terry.reedy
Recipients ezio.melotti, michael.foord, pitrou, serhiy.storchaka, terry.reedy, vajrasky
Date 2013-08-17.12:27:06
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1376742426.87.0.402561775862.issue18702@psf.upfronthosting.co.za>
In-reply-to
Content
You changed "NNTP_CLASS = nntplib.NNTP_SSL", which could potentially fail, to "NNTP_CLASS = getattr(nntplib, 'NNTP_SSL', None)", which cannot fail.  Since that was the only thing that previously could fail, the change leaves nothing that can fail, so the test is not a test.

I suggested that you either not add the third param, a default, or that you remove the null test completely. If particular, if the only chunk of code in nntplib that is currently being tested is being executed by some other test, then do the latter.
History
Date User Action Args
2013-08-17 12:27:06terry.reedysetrecipients: + terry.reedy, pitrou, ezio.melotti, michael.foord, serhiy.storchaka, vajrasky
2013-08-17 12:27:06terry.reedysetmessageid: <1376742426.87.0.402561775862.issue18702@psf.upfronthosting.co.za>
2013-08-17 12:27:06terry.reedylinkissue18702 messages
2013-08-17 12:27:06terry.reedycreate