Author tim.golden
Recipients barry, benhoyt, brian.curtin, dlchambers, ggenellina, ishimoto, lemburg, pitrou, r.david.murray, sayap, terry.reedy, tim.golden
Date 2013-08-12.21:05:35
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <52094E0D.4000405@timgolden.me.uk>
In-reply-to <1376250183.46.0.275892523503.issue15207@psf.upfronthosting.co.za>
Content
Thanks for the review, Ben. Updated patches attached.

1 & 3) default_encoding -- Your two points appear to contradict each 
other slightly. What's in the updated patches is: 3.x has no encoding 
(because everything's unicode end-to-end); 2.7 attempts to apply the 
default encoding -- which is probably ascii -- to the extension and the 
mimetype and continues on error. I'm not 100% sure about this because it 
seems possible if unlikely to have a non-ascii extension / mimetype, but 
this seems like the best compromise (and is no worse than what was there 
before). Does that seem to fit the bill?

2) subkeyname[0] -- done

4) "throws EnvironmentError" -- done

5) test for .png -- done
Files
File name Uploaded
issue15207.27.2.patch tim.golden, 2013-08-12.21:05:35
issue15207.33.2.patch tim.golden, 2013-08-12.21:05:35
History
Date User Action Args
2013-08-12 21:05:35tim.goldensetrecipients: + tim.golden, lemburg, barry, terry.reedy, ishimoto, ggenellina, pitrou, sayap, r.david.murray, brian.curtin, benhoyt, dlchambers
2013-08-12 21:05:35tim.goldenlinkissue15207 messages
2013-08-12 21:05:35tim.goldencreate