Author belopolsky
Recipients belopolsky, gregory.p.smith, pitrou, ronaldoussoren, steven.daprano
Date 2013-08-03.03:02:19
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1375498939.37.0.636197500721.issue18606@psf.upfronthosting.co.za>
In-reply-to
Content
Is there a reason why there is no "review" link?  Could it be because the file is uploaded as is rather than as a patch?

In any case, I have a question about this code in sum:

                # Convert running total to a float. See comment below for
                # why we do it this way.
                total = type(total).__float__(total)

The "comment below" says:

            # Don't call float() directly, as that converts strings and we
            # don't want that. Also, like all dunder methods, we should call
            # __float__ on the class, not the instance.
            x = type(x).__float__(x)

but this reason does not apply to total that cannot be a string unless you add instances of a really weird class in which case all bets are off and the dunder method won't help much.
History
Date User Action Args
2013-08-03 03:02:19belopolskysetrecipients: + belopolsky, gregory.p.smith, ronaldoussoren, pitrou, steven.daprano
2013-08-03 03:02:19belopolskysetmessageid: <1375498939.37.0.636197500721.issue18606@psf.upfronthosting.co.za>
2013-08-03 03:02:19belopolskylinkissue18606 messages
2013-08-03 03:02:19belopolskycreate