This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author jdennis
Recipients eric.araujo, ezio.melotti, flox, jdennis, julien.phalip, r.david.murray
Date 2013-07-18.14:12:31
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1374156751.32.0.0225823908923.issue16611@psf.upfronthosting.co.za>
In-reply-to
Content
I think your basic approach is fine and it's O.K. to break backwards compatibility. I'm not sure anyone was using the httponly and secure flags in the past because it was so broken, the logic was completely contradictory, so backwards compatibility should not trump fixing obviously broken logic.

I didn't review your patch carefully, just a really quick glance. The one thing that did pop out was compiling the static regexp every time the function is called. Why not make it a module or class object and compile once at load time?
History
Date User Action Args
2013-07-18 14:12:31jdennissetrecipients: + jdennis, ezio.melotti, eric.araujo, r.david.murray, flox, julien.phalip
2013-07-18 14:12:31jdennissetmessageid: <1374156751.32.0.0225823908923.issue16611@psf.upfronthosting.co.za>
2013-07-18 14:12:31jdennislinkissue16611 messages
2013-07-18 14:12:31jdenniscreate