Author zach.ware
Recipients brian.curtin, jkloth, loewis, tim.golden, zach.ware
Date 2013-07-11.21:12:03
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1373577123.96.0.965104666733.issue15968@psf.upfronthosting.co.za>
In-reply-to
Content
I'm not sure that moving the tcltk output dir into PCbuild is the right way to go about making different versions of Tcl/Tk available to different Python versions.  For one, because it's not true if you're working out of a single checkout for multiple versions.  I think I'd rather see 'tcltk'/'tcltk64' stay where they are, but grow extensions to denote different builds--'tcltk-Win32-py34' and 'tcltk-x64-py35', for example.  Also, PCbuild/rt.bat needs to be updated if tcltk[64] is changed.

I can't comment much on buildlib.py as I haven't had the time to learn everything I'd need to to understand it all, but it seems to work well doing what it is meant to do.  However, it does seem like substantial overkill for what the comment at the top says it is for :P

Barring the issues I've raised so far, I really like the general idea and direction of the patch.  I really hope this can make it to inclusion before too long.
History
Date User Action Args
2013-07-11 21:12:04zach.waresetrecipients: + zach.ware, loewis, tim.golden, jkloth, brian.curtin
2013-07-11 21:12:03zach.waresetmessageid: <1373577123.96.0.965104666733.issue15968@psf.upfronthosting.co.za>
2013-07-11 21:12:03zach.warelinkissue15968 messages
2013-07-11 21:12:03zach.warecreate