Author pitrou
Recipients Arfrever, Guido.van.Rossum, asvetlov, barry, brett.cannon, chris.jerdonek, cvrebert, eric.snow, ezio.melotti, gvanrossum, pitrou, python-dev, serhiy.storchaka, theller
Date 2013-07-02.15:01:11
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <686107171.135407623.1372777265361.JavaMail.root@zimbra10-e2.priv.proxad.net>
In-reply-to <1372777143.99.0.886696155706.issue15767@psf.upfronthosting.co.za>
Content
> In this instance where there are only a set number of options are
> expected to be officially valid, yes I think enums are a good fit.

They are a good fit, that doesn't mean they're the only one.

> As for strings, the only way I would be okay with that is defining
> the strings either as attributes on ImportError itself or off of
> importlib to make it easy to do a comparison.

What does that mean?
I don't understand how `exc.reason == 'module_not_found'` is
harder than `exc.reason == ImportReason.MODULE_NOT_FOUND`.
History
Date User Action Args
2013-07-02 15:01:11pitrousetrecipients: + pitrou, gvanrossum, barry, brett.cannon, theller, ezio.melotti, Arfrever, cvrebert, asvetlov, chris.jerdonek, python-dev, eric.snow, serhiy.storchaka, Guido.van.Rossum
2013-07-02 15:01:11pitroulinkissue15767 messages
2013-07-02 15:01:11pitroucreate