This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author neologix
Recipients christian.heimes, neologix, serhiy.storchaka
Date 2013-06-30.17:34:14
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CAH_1eM3wdM19c_Jw7So3EOs2s8YHNj0om7T=zx=KZv4EuOi1bA@mail.gmail.com>
In-reply-to <1372604470.25.0.249522670782.issue18328@psf.upfronthosting.co.za>
Content
> I think it's unsafe. The address of a pointer should not be used once the pointer has been freed.

Dereferencing a freed pointer is unsafe. A pointer is just an address,
there's nothing inherently unsafe with comparing a pointer with a
value. The only thing that could go wrong is if the same address was
reused in between which could end up screwing your code logic, but
since here the TLS can only be set by the current thread, I think it's
perfectly safe.

> How about we reverse the order? At first we remove the key from TLS and then free the tstate.

Looks good to me!
History
Date User Action Args
2013-06-30 17:34:14neologixsetrecipients: + neologix, christian.heimes, serhiy.storchaka
2013-06-30 17:34:14neologixlinkissue18328 messages
2013-06-30 17:34:14neologixcreate