Author vstinner
Recipients christian.heimes, dilettant, giampaolo.rodola, jcea, loewis, movement, neologix, pitrou, python-dev, r.david.murray, vstinner
Date 2013-06-22.23:53:34
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1371945214.35.0.606300223477.issue11016@psf.upfronthosting.co.za>
In-reply-to
Content
> New changeset e5427b0b2bf7 by Victor Stinner in branch 'default':
> Issue #11016: Try to fix compilaton of the new _stat.c module on Windows
> http://hg.python.org/cpython/rev/e5427b0b2bf7

@Christian: Can you please review this commit?

By the way, mode_t is also defined in import.c:

#ifdef MS_WINDOWS
/* for stat.st_mode */
typedef unsigned short mode_t;
/* for _mkdir */
#include <direct.h>
#endif

And stat_filemode() should detect integer overflow. mode_t is a 32-bit unsigned integer on Linux, and now a 16-bit integer on Windows, whereas stat_filemode() uses an unsigned long (which 32 bit on Windows, and 32 or 64 bits on Linux).
History
Date User Action Args
2013-06-22 23:53:34vstinnersetrecipients: + vstinner, loewis, jcea, pitrou, movement, giampaolo.rodola, christian.heimes, r.david.murray, neologix, python-dev, dilettant
2013-06-22 23:53:34vstinnersetmessageid: <1371945214.35.0.606300223477.issue11016@psf.upfronthosting.co.za>
2013-06-22 23:53:34vstinnerlinkissue11016 messages
2013-06-22 23:53:34vstinnercreate