Message190697
I left a few minor comments on rietveld for the last patch. I did not see code for time.now() and I don't think adding now() should be combined with time +/- timedelta patch. Let's do one thing at a time.
I think time + timedelta addition is fairly uncontroversial. In the past, I argued against using detached time objects, but it is not really a valid reason for rejecting a good feature.
On subtraction, if we add time - timedelta -> time, I think users would expect time - time -> timedelta as well. This, however, is ambiguous if we stay with mod 24h arithmetic. The ambiguity can be lifted by requiring days=0 in the result. |
|
Date |
User |
Action |
Args |
2013-06-05 22:05:48 | belopolsky | set | recipients:
+ belopolsky, ronaldoussoren, eric.smith, maker, petri.lehtinen, francismb, thezulk, joar, jbatista |
2013-06-05 22:05:48 | belopolsky | set | messageid: <1370469948.13.0.0145008149013.issue17267@psf.upfronthosting.co.za> |
2013-06-05 22:05:48 | belopolsky | link | issue17267 messages |
2013-06-05 22:05:47 | belopolsky | create | |
|