Message190635
After searching through tkinter.py for '_default_root', the patch looks better. The point I missed before is that Tk().__init__(self,...) normally calls _loadtk(self) which installs self as _default_tk if it was None before. So the new function will return the same Tk object each call after the first (unless _default_tk is somehow reset to None.) This also means that the assignment in BaseWidget.setup, "_default_root = Tk()", which the patch deletes, is redundant and misleading, and should go.
I think 'getmaster' or 'get_master' would be a better name than 'setup_master' as setting up a new master is the 2nd backup choice and will happen only once in a session. Most call will get an existing master -- either the one passed in or the once stored as _default_root
The patch needs to be updated for 3.4 and run with current tests. |
|
Date |
User |
Action |
Args |
2013-06-05 01:24:14 | terry.reedy | set | recipients:
+ terry.reedy, gpolo |
2013-06-05 01:24:13 | terry.reedy | set | messageid: <1370395453.94.0.856336733302.issue4343@psf.upfronthosting.co.za> |
2013-06-05 01:24:13 | terry.reedy | link | issue4343 messages |
2013-06-05 01:24:12 | terry.reedy | create | |
|