Message190572
The patch to configSectionNameDialog.py fixes the human test (adds required arg) so it runs, adds instructions to the test, fixes a bug in name_ok, removes redundant code, adds needed spaces, de-camelcases internal names, and changes the master for the two StringVars so they can be collected [sys:1: ResourceWarning: gc: 2 uncollectable objects at shutdown [<tkinter.StringVar object at 0x02C597E0>, <tkinter.StringVar ...]]. (I plan to open an issue about this.)
The new mock_tk.py adds generic mocks for tkinter String/Int/BooleanVars and tkinter.messagebox and its 8 functions. The new test_name_dialog.py uses these to unittest the non-gui parts of the dialog.
The backport to 2.7 required changes to the tkinter imports and print in configSectionNameDialog.py and in test_config_name.py, addition of '.im_func' to the names of methods/functions being added to the dummy class.
Both unittests and human tests run on all three branches. I believe the patches are ready to commit. |
|
Date |
User |
Action |
Args |
2013-06-04 00:15:20 | terry.reedy | set | recipients:
+ terry.reedy |
2013-06-04 00:15:19 | terry.reedy | set | messageid: <1370304919.98.0.573433611159.issue18130@psf.upfronthosting.co.za> |
2013-06-04 00:15:19 | terry.reedy | link | issue18130 messages |
2013-06-04 00:15:19 | terry.reedy | create | |
|