Message189897
I finally had some time so here's an updated patch (including O(1) deletions). I've also added a bunch of notes at the top of odictobject.c. Some notable things left to do:
* address two recently failing tests due to r83881 (issue 17900)
* check for any reference cycles (should be fine)
* validate reentrancy (make sure everything is thread-safe around calls into Python)
* make sure subclassing is okay
* compare performance to dict, pure Python OrderedDict
My goal here is to get an effective OrderedDict that we are happy with, while recognizing that there is room for optimization. However, I won't be okay with faultiness, so the implementation must be complete. This has been my mindset throughout. |
|
Date |
User |
Action |
Args |
2013-05-24 05:57:00 | eric.snow | set | recipients:
+ eric.snow, rhettinger, benjamin.peterson, ezio.melotti, eric.araujo, alex, asvetlov, flox, serhiy.storchaka |
2013-05-24 05:57:00 | eric.snow | set | messageid: <1369375020.46.0.125444740886.issue16991@psf.upfronthosting.co.za> |
2013-05-24 05:57:00 | eric.snow | link | issue16991 messages |
2013-05-24 05:57:00 | eric.snow | create | |
|