Author neologix
Recipients Yogesh.Chaudhari, dilettant, ezio.melotti, giampaolo.rodola, kushal.das, nedbat, neologix, pitrou, python-dev, r.david.murray, serhiy.storchaka, trent, vstinner
Date 2013-05-20.15:43:00
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <CAH_1eM1D7nzt5ueZc_FXEU9XFPiqH_5u-Z1uJE+N3rEiM3F_iw@mail.gmail.com>
In-reply-to <1369055295.02.0.285535187339.issue17914@psf.upfronthosting.co.za>
Content
>  * rewrite Mac OS X implementation: code in 5e0c56557390 looks wrong. It
> gets a MIB but then don't use it when calling _bsd_cpu_count(). But I didn't
> check my patch nor the commit version on Mac OS X.

Indeed.
I just removed the OS-X special case altogether.
Apparently, the standard sysctl is supposed to work os OS-X.
We'll see what happens.

>  * use "int ncpu;" instead of "long ncpu;" when calling mpctl() and
> sysctl(). For mpctl(), ncpu is used to store the result, so a wide type is
> ok. But for sysctl(), we pass a pointer. What happens if sysctl() expects
> int whereas we pass a pointer to a long? We announce sizeof(int)!?

Ouch. This was overlooked when the type was changed to long.
I fixed this.

>  * inline _bsd_cpu_count()

Done in a subsequent commit (especially since the OS-X special case
has been removed).
History
Date User Action Args
2013-05-20 15:43:00neologixsetrecipients: + neologix, pitrou, vstinner, giampaolo.rodola, nedbat, trent, ezio.melotti, r.david.murray, python-dev, serhiy.storchaka, kushal.das, dilettant, Yogesh.Chaudhari
2013-05-20 15:43:00neologixlinkissue17914 messages
2013-05-20 15:43:00neologixcreate