Author vstinner
Recipients Yogesh.Chaudhari, dilettant, ezio.melotti, giampaolo.rodola, kushal.das, nedbat, neologix, pitrou, python-dev, r.david.murray, serhiy.storchaka, trent, vstinner
Date 2013-05-20.13:08:14
SpamBayes Score -1.0
Marked as misclassified Yes
Message-id <1369055295.02.0.285535187339.issue17914@psf.upfronthosting.co.za>
In-reply-to
Content
In my patch cpu_count.patch, I changed posix_cpu_count():

 * rewrite Mac OS X implementation: code in 5e0c56557390 looks wrong. It gets a MIB but then don't use it when calling _bsd_cpu_count(). But I didn't check my patch nor the commit version on Mac OS X.
 * use "int ncpu;" instead of "long ncpu;" when calling mpctl() and sysctl(). For mpctl(), ncpu is used to store the result, so a wide type is ok. But for sysctl(), we pass a pointer. What happens if sysctl() expects int whereas we pass a pointer to a long? We announce sizeof(int)!?
 * inline _bsd_cpu_count()

Sorry for this late review.
History
Date User Action Args
2013-05-20 13:08:15vstinnersetrecipients: + vstinner, pitrou, giampaolo.rodola, nedbat, trent, ezio.melotti, r.david.murray, neologix, python-dev, serhiy.storchaka, kushal.das, dilettant, Yogesh.Chaudhari
2013-05-20 13:08:15vstinnersetmessageid: <1369055295.02.0.285535187339.issue17914@psf.upfronthosting.co.za>
2013-05-20 13:08:15vstinnerlinkissue17914 messages
2013-05-20 13:08:14vstinnercreate