On Sun, 19 May 2013, R. David Murray wrote:

RDM> 
RDM> R. David Murray added the comment:
RDM> 
RDM> Lorenzo, any chance you could supply a unit test that fails without 
RDM> smtplib_05_shutdown_socket.diff applied?
RDM> 

It would really be a functional test, since the problem with half-open 
connection pile-up stems from smtp server's access control rules.

To test we should setup a fake smtp server, which forbids having multiple
connections from the same IP address, and connect twice in a row to the 
fake server. I'm not sure I'm able to implement both an smtpd.py server
serving more than one connection and the client code in a race-free way in 
the same "unit" test. Will try in the next week.

Thank you very much,

	lorenzo