Message189523
A fix for a DeprecationWarning (#17678) had the unfortunate side effect of changing the expected interface of the request object higher up in the call stack.
For example, the documentation for CookieJar.add_cookie_header(request) states that the request object must support the methods get_full_url(), get_host(), get_type(), unverifiable(), get_origin_req_host(), has_header(), get_header(), header_items(), and add_unredirected_header(). The patch for #17678, however, changes the requirement for a get_origin_req_host() method to an origin_req_host attribute.
This breaks at least one notable third-party library (Kenneth Reitz' Requests). |
|
Date |
User |
Action |
Args |
2013-05-18 15:45:02 | sinic | set | recipients:
+ sinic, orsenthil, docs@python |
2013-05-18 15:45:02 | sinic | set | messageid: <1368891902.97.0.967044954731.issue18007@psf.upfronthosting.co.za> |
2013-05-18 15:45:02 | sinic | link | issue18007 messages |
2013-05-18 15:45:02 | sinic | create | |
|